2009/4/11 James Hawkins truiken@gmail.com:
On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam niko.lecam@gmail.com wrote:
2009/4/10, James Hawkins truiken@gmail.com:
On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam niko.lecam@gmail.com wrote:
Try2: This time with the patch.
Tested on Win2k/WinXP. Marked two tests as todo_wine.
I was serious before. You can't change the old tests. Please add new tests for the exposed bugs. Same goes for patch 3/4.
-- James Hawkins
I will for test 4 but test 3 wasn't correct before. It was assuming drive was current one and that wasn't correct as revealed by my patch. This was only right if run on systemdrive and not from root drive dir.
You're missing the point. Even in 3/4 you are adding a todo_wine where there was none before. By definition, you are changing what is being tested. The test was not incorrect, it just didn't cover all corner cases. Like I said before, I have no problem with you adding a new test to tickle this bug you've found, but in your attempts to 'fix' the test for this corner case, you cannot add a todo_wine here. This requires you to acquire a deeper understanding of what is being tested instead of blindly throwing new code at the test.
-- James Hawkins
Let met explain :
Running test on wine in folder C:\test : works (expected "C:\test" got "C:\test") Running test on wine in folder C:\ : works (expected "C:" got "C:") Running test on wine in folder Z:\home\nlecam\Projects\wine\wine-git\dlls\msi\tests : works (expected "Z:\home\nlecam\Projects\wine\wine-git\dlls\msi\tests" got "Z:\home\nlecam\Projects\wine\wine-git\dlls\msi\tests") Running test on Windows in folder C:\test : works (expected "C:\test" got "C:\test") Running test on Windows in folder C:\ : fails (expected "C:" got "") Running test on Windows in folder X:\Documents And Settings\nlecam\Desktop : fails (expected "X:\Documents And Settings\nlecam\Desktop" got "C:\Documents And Settings\nlecam\Desktop")
That's why I considered it was incorrect. It only worked on a corner case, and never failed on Windows because it was certainly launched from C:\something every time. The only thing I can do to make this test completely correct is to check if expected directory is on SystemDrive and isn't the root drive directory, in this case the todo_wine isn't needed, i.e. limit current test to its corner case, mark it todo_wine and add second possible result in all other cases.