2016-03-01 14:49 GMT+01:00 Paul Gofman gofmanp@gmail.com:
Matteo,
thank you for the review, I will be following up. Regarding splitting the test, do you suggest introducing separate
test functions or just adding tests into the same one step by step?
I just meant to split the test out of the implementation patch(es), not necessarily to split the test over a number of patches, although I guess the question is also valid for future extensions to the test. The answer is "it depends", it's usually fine to add more stuff into the same test as long as it's adding related stuff, it's easy to integrate and it doesn't make the test too large.
Regards, Paul.