Re: [PATCH] include: Include x86intrin.h in msvcrt/intrin.h.

[Jacek Caban]

Signed-off-by: Jacek Caban

---

On 15.03.2021 16:07, Rémi Bernon wrote:
> Signed-off-by: Rémi Bernon
>
> Supersedes: 201370
>
> AFAIU x86intrin.h is a GCC/Clang specific header, but I think __i386__
> and __x86_64__ are too so we don't need _MSC_VER guard here? But the
> same seems to be true for __arm__ so I'm not sure why there's such guard
> around __dmb intrinsics below.

No, it's not GCC specific and I think that we actually want to use it on 
clang msvc target (like your patch does).

FWIW, if it was just for sake of __rdtsc and __rdtscp, I'd say that we 
could just use inline assembly. However, I think that having functional 
intrin.h is nice to have and this change will be useful in the future.

Thanks,

Jacek