Re: [PATCH v4 9/9] qedit: Implement MediaDet_get_StreamLength.

[Zebediah Figura]

On 4/24/20 6:25 AM, Gabriel Ivăncescu wrote:
> On 23/04/2020 22:48, Zebediah Figura wrote:
> > On 4/21/20 7:19 AM, Gabriel Ivăncescu wrote:
> > > -
> > >        hr = IMediaSeeking_ConvertTimeFormat(seeking, &duration, &, duration, NULL);
> >
> > According to my testing, Windows doesn't do this.
>
> Yeah, I assumed it's a bug, since it doesn't call any of the time 
> functions either, it just assumes it's TIME_FORMAT_MEDIA_TIME or something?
>
> Should I drop this and just assume so, too? Do you think it's worth? 
> (perhaps I can just ignore the return value instead?)

It could be called a bug, yes; it seems the DirectShow documentation
doesn't specify that the default time format should be reference time.
But it results in less code for us to replicate that bug.

According ot my tests the return value of GetDuration() is checked, so
no reason to get rid of that.