On 04.07.2015 11:46, Dmitry Timoshkov wrote:
Besides, my patch fixes a regression caused by IStorage locking rewrite, and should be pretty obvious without a test case. With this regression fixed an application that I have here can open its database files again as it was before.
If you really insist on a test case, please ask Vincent, he is the original authour of this implementation.
He's not the one sending this, so why should he be writing tests for your changes?
My patch just adds another obvious case of a possible ILockBytes failure. If the tests were not needed for an already existing case then my patch changes nothing in that regard.
Asking for a test especially if you found a regression is not uncommon. Your change brings inconsistency in error handling as I mentioned already, and it's not obvious at all what errors should be ignored. I really don't understand why are you so resistant sometimes.
Fixing a regression with a pretty obvious fix shouldn't deserve so much of salt from your side Nikolay.
...