Re: [PATCH] msvcp: Set correct error code on non-existing path in _Open_dir.

[Piotr Caban]

Signed-off-by: Piotr Caban

On 1/25/19 1:59 AM, Gijs Vermeulen wrote:
> diff --git a/dlls/msvcp120/tests/msvcp120.c b/dlls/msvcp120/tests/msvcp120.c
> index ac38aa61a0..6d72f9fd68 100644
> --- a/dlls/msvcp120/tests/msvcp120.c
> +++ b/dlls/msvcp120/tests/msvcp120.c
> @@ -1837,7 +1837,7 @@ static void test_tr2_sys__dir_operation(void)
>       result_handle = file;
>       result_handle = p_tr2_sys__Open_dir(first_file_name, "not_exist", &err, &type);
>       ok(result_handle == NULL, "tr2_sys__Open_dir(): expect: NULL, got %p\n", result_handle);
> - todo_wine ok(err == ERROR_BAD_PATHNAME, "tr2_sys__Open_dir(): expect: ERROR_BAD_PATHNAME, got %d\n", err);
> - ok(err == ERROR_BAD_PATHNAME, "tr2_sys__Open_dir(): expect: ERROR_BAD_PATHNAME, got %d\n", err);
>  ok((int)type == 0xdeadbeef, "tr2_sys__Open_dir(): expect: 0xdeadbeef, got %d\n", type);
>  ok(!*first_file_name, "tr2_sys__Open_dir(): expect: 0, got %s\n", first_file_name);

While you're at it, could you please also change the memset in tests to 
fill first_file_name buffer with e.g. 0xff bytes and fix the implementation?

Thanks,
Piotr