Re: [PATCH 2/2] mf: Finalize sinks right after they have been stopped.

[Nikolay Sivov]

On 6/22/21 5:01 PM, Rémi Bernon wrote:
> As session_set_source_object_state does not call session_finalize_sinks
> if session is already stopped.
>
> Guilty Gear Strive otherwise gets stuck on character selection screen
> as it waits for the MESessionClosed event forever.
> Signed-off-by: Rémi Bernon
>
> I'm not completely sure about the logic here. Maybe we should instead
> make session_set_source_object_state with SESSION_STATE_STOPPED state
> and SESSION_FLAG_FINALIZE_SINKS flag call session_finalize_sinks,
> or instead make sure to force session state after session_set_stopped
> call to SESSION_STATE_STOPPING_SOURCES here.

Yes, something is not right, I'll have to experiment with finalization
step again, I don't remember how it works now.