Re: [PATCH] include: Include x86intrin.h in msvcrt/intrin.h.

[Jacek Caban]

On 16.03.2021 17:40, Rémi Bernon wrote:
> On 3/16/21 5:36 PM, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban
> >
> > On 15.03.2021 16:07, Rémi Bernon wrote:
> > > Signed-off-by: Rémi Bernon
> > >
> > > Supersedes: 201370
> > >
> > > AFAIU x86intrin.h is a GCC/Clang specific header, but I think __i386__
> > > and __x86_64__ are too so we don't need _MSC_VER guard here? But the
> > > same seems to be true for __arm__ so I'm not sure why there's such 
> > > guard
> > > around __dmb intrinsics below.
> >
> > No, it's not GCC specific and I think that we actually want to use it 
> > on clang msvc target (like your patch does).
>
> Ah yes, but what I meant was that MSVC doesn't have it. Is clang msvc 
> target defining _MSC_VER too?

Yes, it defines _MSC_VER. Also see:

https://source.winehq.org/git/wine.git/blob/HEAD:/configure.ac#l2734

Jacek