On Mon, Jan 6, 2020 at 3:34 PM Sven Baars sbaars@codeweavers.com wrote:
From: Alistair Leslie-Hughes leslie_alistair@hotmail.com
Signed-off-by: Sven Baars sbaars@codeweavers.com
Hi Sven,
I finally got around to review this patch series. Comments following...
v2: Use Tahoma
dlls/d3dx9_36/tests/core.c | 63 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+)
diff --git a/dlls/d3dx9_36/tests/core.c b/dlls/d3dx9_36/tests/core.c index 75146575be..8c1d41e952 100644 --- a/dlls/d3dx9_36/tests/core.c +++ b/dlls/d3dx9_36/tests/core.c @@ -637,6 +637,69 @@ static void test_ID3DXFont(IDirect3DDevice9 *device)
ID3DXFont_Release(font); }
- /* ID3DXFont_DrawTextA, ID3DXFont_DrawTextW */
- hr = D3DXCreateFontA(device, 12, 0, FW_DONTCARE, 0, FALSE, DEFAULT_CHARSET, OUT_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH, "Tahoma", &font);
- if (SUCCEEDED(hr)) {
This is never supposed to fail, so I'd get rid of the if entirely (replacing it with a ok()).
RECT rect;int height;todo_wine {SetRect(&rect, 10, 10, 200, 200);height = ID3DXFont_DrawTextA(font, NULL, "test", -2, &rect, 0, 0xFF00FF);ok(height == 12, "DrawTextA returned %d, expected 12.\n", height);
It would be nice to know if this test was prompted by debugging some game or just random testing.