Re: [PATCH 1/2] cmd: Use terminated strings in WCMD_ReadAndParseLine()

[Gijs Vermeulen]

Op wo 14 apr. 2021 om 07:21 schreef Hugh McMaster <[e-mail]
> :
> While the sizeof() calculations in the ARRAY_SIZE() macro occur at
> compile-time (meaning no cost), lstrlenW() and friends are highly
> optimized for speed. Some implementations of strlen() are even written
> in assembly for even more speed.
>
> Given the string lengths being checked seem to be <= 5, any cost is
> extremely minimal at best.

Understood.
> I'm not sure if anyone else has any thoughts on this, but I still
> think calculating string length in WCMD_keyword_ws_found() will work
> better.

I will just rework the series to do this instead. Thanks for all the
comments/reviews.