Re: [PATCH 3/7] wsdapi: Build and write Types list for Hello message.

[Huw Davies]

On Fri, Apr 20, 2018 at 08:16:55AM +0000, Owen Rudge wrote:
> Hi Huw,
> > Is it possible that list could be NULL so that the while loop is never
> > executed?  If so, then the above line would touch buffer[-1].  If
> > list is never NULL consider rewriting the loop as a do-while.
>
> No, the list is checked for NULL in the calling function. I can rewrite it as a do-while though for clarity.

While you're at it, is that ZeroMemory() call really necessary?

Huw.