On 9/1/22 12:05, Francois Gouget wrote:
I pushed a merge request with the latest version so you can also comment there: https://gitlab.winehq.org/wine/wine/-/merge_requests/764
See also my flaky-tests branch for some use cases: https://gitlab.winehq.org/fgouget/wine/-/commits/flaky-tests/
On to the next question: do we need to take special steps to make sure one cannot just (sneakily?) add bad tests by prefixing them with flaky*?
One option is to do nothing and let reviewers deal with it. Certainly if they spot a flaky addition they would scrutinize the patch and ask questions as needed. And if bad flaky calls slip through, the developer's trustiness would be adjusted accordingly.
Why would we allow (intentionally) adding any flaky tests at all? My interpretation of "flaky" is that anything that currently has it is a bug and should be fixed.