Re: [1/3] comctl32/tab: Add a test for TCM_SETITEMEXTRA

[Nikolay Sivov]

On 9/27/2010 10:14, Vitaliy Margolen wrote:
> On 09/26/2010 05:08 PM, Nikolay Sivov wrote:
> > Add a test for TCM_SETITEMEXTRA
> > +static HWND parent_wnd;
> > -static void test_curfocus(HWND parent_wnd, INT nTabs)
> > +static void test_curfocus(void)
> >  {
> > - hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH,
> >
> > TCIF_TEXT|TCIF_IMAGE, nTabs);
> > - hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH,
> >
> > TCIF_TEXT|TCIF_IMAGE, 5);
>
> So how is the global better then function parameter? Or a magic number?

We always use the same parent window and I don't see a reason of having 
more parent windows for tests, so this kind of flexibility is useless 
here. Same for tab count - we don't run test with tables or even with 
different tab count so it makes no sense to pass it as parameter.
> Vitaliy.