On Mon, 12 Nov 2012, Jacek Caban wrote:
On 11/12/12 13:21, Marvin wrote:
[...]
=== W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2596: Test failed: expected GetOverridesKeyPath webbrowser.c:2601: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2602: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3015: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402F21
That's TestBot not skipping on platforms that should be skipped.
We can potentially change the criteria that TestBot uses to decide whether to skip. But what should these be here? Also, do they really belong in WineTestBot, which would likely require duplicating that code to WineTest too, or should the skipping really be done by the test itself?