Re: [PATCH] FCI work for cabinet.dll [cabinet-fci-patch-02b.diff]

[Dimi Paun]

On Sat, 2005-06-11 at 16:37 +0200, Gerold J. Wucherpfennig wrote:
> In my opinion BOOL is a crap and a real shortcoming
> of the C programming language.

[...]
> And last: if(fNextCab==TRUE) makes it more obvious for the quick
> source code reader when a BOOL value is compared than if(fNextCab).

Well, like it or not, that's the semantics in C. This is not a matter of
preference like the indentation, but a matter of potentially introducing
very hard to find bugs.

Also remember that in many cases, we are dealing with values that are
set by the application, and are not under our control. For those we must
not do fBool == TRUE. It would be confusing to have two very different
ways to test for TRUE.