On Mon, May 4, 2009 at 2:43 PM, Austin English austinenglish@gmail.com wrote:
On Mon, May 4, 2009 at 12:19 PM, Juan Lang juan.lang@gmail.com wrote:
We have a similar warning already: http://source.winehq.org/git/wine.git/?a=blob;f=dlls/ws2_32/tests/sock.c#l24...
That warning is appropriate, because it's testing IPv6, so the warning applies in all cases. The reason I'm objecting in this case is that the warning is printed for any failure, no matter which chain is being checked, yet this condition can only occur on one of the 15 or so chains that are checked. Like I said, I think it's a special case.
How about an if ( got->dwErrorStatus = CERT_TRUST_IS_UNTRUSTED_ROOT ) ?
-- -Austin
Alternatively, how about printing an error in crypt32 itself if no trusted root certificates are found? That way applications get the same benefit, not just the test suite? E.g., how we do for ntlm_auth in secur32?