Re: DirectDrawRenderer - opengl non power of 2 windows

[Nathan Williams]

Actually I needed to set that flag, otherwise other code further on
fails, using the incorrect height. And now that I look at it, all my
bitwise operator knowledge is coming back from university, that should
have been a bitwise or!

so:
This->Flags |= SFLAG_NONPOW2;

I'll fix it and resend an updated patch.

On 3/31/07, Stefan Dösinger  wrote:
> > @@ -3194,6 +3193,7 @@ static HRESULT WINAPI
>
> IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) {
> > } else {
> >     /* No oversize, gl rect is the full texture size */
> >      This->Flags &= ~SFLAG_OVERSIZE;
> > -
> >    This->Flags &= SFLAG_NONPOW2;
>
> This is not correct. This removes every flag except SFLAG_NONPOW2. If you want
> to remove the SFLAG_NONPOW2 flag you have to invert the flag:
>
> This->Flags &= ~SFLAG_NONPOW2