On Sat, Nov 21, 2015 at 2:12 PM, Jamie Taylor Jamie.Taylor@pobox.com wrote:
There were many shortcomings in the previous behavior, but most importantly it resulted in the first IP address in the returned hostent structure being the magic loopback address in the default network configuration on Mac OS X. The new behavior returns all IP addresses from non-loopback network adapters, and ensures that the addresses from the adapter for the default route are at the front of the list. Testing confirmed this behavior on Mac OS X.
This will most likely fix https://bugs.winehq.org/show_bug.cgi?id=37271 and https://bugs.winehq.org/show_bug.cgi?id=22819 but I do not have the programs under test in those bugs, so I can't verify.
I also do not have convenient access to a linux machine with an equivalent network configuration (i.e., at least two interfaces with default routes) to test.
Hi, Jamie. Thanks for your effort, as you may have observed in the patches list your patch is marked as deferred because we are in code freeze for Wine 1.8 release. This code was touched a few times in attempts to fix this same issue you are addressing so maybe this time it will be the definitive fix =)
I have a similar (not so robust) old patch that I used on FreeBSD (and also works in Linux), could you try it in OSX just out of curiosity, please? It has printf to help showing the results so a make test in the ws2_32/tests folder is enough to check if it works.
About your patch I just would like to say that you should follow the surrounding code style, so the { goes in the next line. I tested it on Linux and it works for Heroes of Might & Magic 2 (https://bugs.winehq.org/show_bug.cgi?id=22819).
Best wishes, Bruno