On 6/19/06, Robert Shearman rob@codeweavers.com wrote:
This needs to be cleaned up a lot more before it will be accepted.
For a start, the members of this structure need to be cleaned up. Some of the members of the POPUPMENU structure are for keeping track of the menu while it's in use (bTimeToHide, bScrolling, nScrollPos, FocusedItem), so these could be kept on the client side. Also, everything needs to be converted to wineserver types.
It should become clear what needs to change as menu item handling is moved into the server, so I would urge you to work on that and then rework these patches.
Hi Rob,
Thanks for your input. I've reworked the first set of patches with your suggestions and moved menu item data into the server. The patch series (11 of them) are at http://silenceisdefeat.org/~tkho/seas/wine/patches/menu-0627-8/.
I tried to make as little changes as possible, and most of the code is still client-side. Apps seem just as responsive, and all conformance tests still pass. Should I try to integrate more functionality into the server, or get these 11 patches committed?
Tommy