Re: [PATCH 2/2] d3drm: Implement IDirect3DRMViewport*::Clear. (v3 resend)

[Henri Verbeet]

On 15 August 2016 at 21:50, Aaryaman Vasishta  wrote:
> - memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID));

Why not "driver = IID_IDirect3DRGBDevice;"?

It probably also makes sense to introduce a helper function to create
d3drm devices at some point.
> - hr = IDirect3DMaterial_SetMaterial(viewport->material, &mat);
> -
> - return hr;

"return IDirect3DMaterial_SetMaterial(viewport->material, &mat);"
> - if (FAILED(hr = IDirect3DViewport_Clear(viewport->d3d_viewport, 1, &clear_rect, clear_flags)))
> -
>           return hr;

Formatting.