-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-04-29 um 23:47 schrieb Aaryaman Vasishta:
- if (!refcount)
- if (!refcount && !InterlockedDecrement(&d3drm->numIfaces)) HeapFree(GetProcessHeap(), 0, d3drm);
This works, but this way you have the code that destroys the object 3 times. Not much of an issue as long as it is just a HeapFree, but I think it would be nicer to have a separate function. Either add a d3drm_destroy function or a pair of d3drm_add_iface and d3drm_release_iface functions that also take care of InterlockedIncrement / Decrement for iface_count)
{ &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, TRUE },{ &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, TRUE },
{ &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, FALSE },{ &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, FALSE },
Afaics all the TODOs are gone, so you can remove this field from the table and the todo_wine code from test_qi(). Either in the same patch or a separate one.
- LONG ref;
- LONG ref1, ref2, ref3, numIfaces;
};
Please use iface_count. Yeah, it's just a plain style thing, but d3drm is nicely consistent so far in not using CamelCase (except in cases where Microsoft determined the name).
(Yesterday on IRC I said num_ifaces. Henri says xxx_count is the way he prefers.)
- if (refcount == 1) InterlockedIncrement(&d3drm->numIfaces);
Another minor style issue: Please put the statement on a separate line, in consistency with the existing code.