Re: [PATCH 2/6] winealsa: Move MIDM_START to the unixlib.

[Andrew Eikum]

Signed-off-by: Andrew Eikum

On Wed, Mar 23, 2022 at 08:16:51AM +0000, Huw Davies wrote:
> Signed-off-by: Huw Davies
>
> dlls/winealsa.drv/alsamidi.c | 18 ++++++++++++++++++
>  dlls/winealsa.drv/midi.c     | 17 -----------------
>  2 files changed, 18 insertions(+), 17 deletions(-)
>
> diff --git a/dlls/winealsa.drv/alsamidi.c b/dlls/winealsa.drv/alsamidi.c
> index 535699a4059..d647ba79a9e 100644
> --- a/dlls/winealsa.drv/alsamidi.c
> +++ b/dlls/winealsa.drv/alsamidi.c
> @@ -942,6 +942,21 @@ static UINT midi_in_get_devcaps(WORD dev_id, MIDIINCAPSW *caps, UINT size)
>      return MMSYSERR_NOERROR;
>  }
>
> +static UINT midi_in_start(WORD dev_id)
> +{
> - struct midi_src *src;
> -
> - TRACE("(%04X);\n", dev_id);
> -
> - if (dev_id >= num_srcs) return MMSYSERR_BADDEVICEID;
> - src = srcs + dev_id;
> - if (src->state == -1) return MIDIERR_NODEVICE;
> -
> - src->state = 1;
> - src->startTime = NtGetTickCount();
> - return MMSYSERR_NOERROR;
>
> +}
> -
>
> static DWORD midi_in_reset(WORD dev_id, struct notify_context *notify)
>  {
>      UINT cur_time = NtGetTickCount();
> @@ -1056,6 +1071,9 @@ NTSTATUS midi_in_message(void *args)
>      case MIDM_GETNUMDEVS:
>          *params->err = num_srcs;
>          break;
> - case MIDM_START:
> -
>    *params->err = midi_in_start(params->dev_id);
> -
>    break;
> case MIDM_RESET:
>        *params->err = midi_in_reset(params->dev_id, params->notify);
>        break;
>
> diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c
> index 5639bf67369..88b23f52ec1 100644
> --- a/dlls/winealsa.drv/midi.c
> +++ b/dlls/winealsa.drv/midi.c
> @@ -459,21 +459,6 @@ static DWORD midClose(WORD wDevID)
>      return ret;
>  }
>
> -/**************************************************************************
> -
> -
> 	midStart				[internal]
> - */
>
> -static DWORD midStart(WORD wDevID)
> -{
> - TRACE("(%04X);\n", wDevID);
> -
> - if (wDevID >= MIDM_NumDevs) return MMSYSERR_BADDEVICEID;
> - if (MidiInDev[wDevID].state == -1) return MIDIERR_NODEVICE;
> -
> - MidiInDev[wDevID].state = 1;
> - MidiInDev[wDevID].startTime = GetTickCount();
> - return MMSYSERR_NOERROR;
>
> -}
> -
>
> /**************************************************************************
> -
> 	midStop					[internal]
>
> */
> @@ -533,8 +518,6 @@ DWORD WINAPI ALSA_midMessage(UINT wDevID, UINT wMsg, DWORD_PTR dwUser,
>    return midOpen(wDevID, (LPMIDIOPENDESC)dwParam1, dwParam2);
>      case MIDM_CLOSE:
>    return midClose(wDevID);
> - case MIDM_START:
> - return midStart(wDevID);
> case MIDM_STOP:
> return midStop(wDevID);
> }
>
> -- 
> 2.25.1