On 1/5/22 21:38, Nikolay Sivov wrote:
On 1/5/22 18:52, Derek Lesho wrote:
On 1/5/22 06:01, Nikolay Sivov wrote:
On 1/4/22 20:35, Derek Lesho wrote:
The sample grabber currently leaks the key on the last invokation of the timer, as it is only released when stream_schedule_sample is called.
It's also released when sample grabber sink is released. Is that not always enough? Or is that useful when sink is reused for next topology?
The problem is that it introduces a circular dependency, the cancel key holds a reference to the timer callback, which contributes to the reference count of the sample grabber stream sink and media sink.
I see, so this could be solved by releasing this key on shutdown, and ensuring that shutdown actually happens. I'll take a look at what's going on with its special IMFActivate vs normal shutdown method.
This better matches what I see from experimenting with the timer. I'll send it after 7.0. Question about properly shutting the sink down still remains.