Re: dpnet: Improve Error checking in Get/Set SP (try 3 Resend )

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-04-08 12:12, schrieb Alistair Leslie-Hughes:
> Hi,
> Any feedback would be good.

A few mostly minor things come to my mind.
> - if(!pguidSP)
> -
>    return DPNERR_INVALIDPOINTER;
>
> ...
> -
>    ok(hr == DPNERR_DOESNOTEXIST, "got 0x%08x\n", hr);
>
> ...
> - ok( hr == S_OK, "failed to init com\n");
> - if (hr != S_OK)

Style inconsistencies.
> - hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&localaddr);

Please avoid LPVOID and similar pointer types. Just use void **.
> -
>    hr = IDirectPlay8Address_SetSP(localaddr, NULL);
> -
>    ok(hr == DPNERR_INVALIDPOINTER, "got 0x%08x\n", hr);
> -
> -
>    hr = IDirectPlay8Address_SetSP(localaddr, &IID_Random);
> -
>    ok(hr == S_OK, "got 0x%08x\n", hr);

Since you're using GUID_NULL as a way to signal that no guid is set it would be a good idea to try to pass it to SetSP and see if you still get DPNERR_DOESNOTEXIST when you call GetSP.

Otherwise this looks good to me.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTQ9jeAAoJEN0/YqbEcdMwDisP/iFE7fHlWn2B0LYwVNgu6lD9
6OQdMWuLYAiWRWQKx9WaBAiwdq6ZmG3WnfHfuLPAI5VkHh0lUZwOTil/J7KQYVoj
rVeCA6wKDHMPXUHcRC0uB7gZlzh5JKCq60iQ4xeJ9CUAk/fhVMOGd8+xXew2HYfo
K4WVyEw8FYg88F+YzQh1dWj4e84dn+yn0+yGYrqSxXOTeJFcal1EOo0myGcZgBto
uLUvFb/NBQFMzwN/mOL84YzY4nRCpIbenQbI+03BT7YR/lX1Q3IOdvTyB+dsN8pQ
iO+ekMEFR0PYOkG6skmLlkAkRHCeq9uxyLHaxvtUPv9NuA+GgvQY6xhXielnVn8f
GGzlvHd01bNjccZQTjSbvE45rsp3/PGuV3592DNbhZGmiZ10D8bY/yu2QW3F6sHP
d9yhyJc4ubi3vlJ0UTUF8joZzL2rSydWvTa5VLNkWhqnZUzJqE2lwG6QI5IqUjra
Khl3W5P5SyFfoBZcWQwHVOURa3IzZOsYQWm6jbjJqrBXphUGg6wZZ1YgfTqlfoqq
vq9Xnr90UulxQHB4txTcviDOQi8EXAOmAIbhSImsam6hCht0A75zuxIP84LhS/mv
UkjblDHxCGneNrkq7tuJiARjwj6D5RJY26iYaw70sHOhJBFKXSzARmtP5At+BwRd
wplsw498wUMBAVjAl/ZB
=TIUo
-----END PGP SIGNATURE-----