Alexandre Julliard wrote:
Shachar Shemesh wine-patches@shemesh.biz writes:
After much talk, the patch seems ready for commit. Since there are many systems with slightly older glibc that have the header but do not have the implementation in glibc, or that have a stub implementation that is guaranteed to fail, we are calling the kernel functions directly. This also allows compiling on older systems than the code actually ships to.
Accordingly, the autoconf checks for epoll_create in glibc were dropped.
That's wrong; if the libc function exists you should use it, direct system calls should only be used as a fallback. And when using system calls you must not depend on the libc header, you have to define the structures yourself.
The problem is that on many platforms, the functions are defined in glibc, but stubbed out to always fail. It seems a waste to lose these platforms.
Shachar