Re: [PATCH 5/7] mfplay: Prevent usage of uninitialized pointer in error case (Coverity)

[Nikolay Sivov]

On 4/23/22 21:17, Fabian Maurer wrote:
> Later we check if they are set before calling IMFTopologyNode_Release,
> but they are possibly never initialized
> Signed-off-by: Fabian Maurer
>
> dlls/mfplay/player.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/mfplay/player.c b/dlls/mfplay/player.c
> index 7d9a4da8649..c8bb04f697e 100644
> --- a/dlls/mfplay/player.c
> +++ b/dlls/mfplay/player.c
> @@ -1378,7 +1378,7 @@ static HRESULT media_item_create_sink_node(IUnknown *sink, IMFTopologyNode **nod
>
> static HRESULT media_item_create_topology(struct media_player *player, struct media_item *item, IMFTopology **out)
>   {
> - IMFTopologyNode *src_node, *sink_node;
> - IMFTopologyNode *src_node = 0, *sink_node = 0;
>  BOOL selected, video_added = FALSE;
>  IMFStreamDescriptor *sd;
>  IMFTopology *topology;
>
> --
> 2.36.0

Yes, this looks good. Let's use NULLs instead of 0s though.