Re: [PATCH v10 0/7] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
>  if (FAILED(hr))
>      goto exit;
>
> - period = pulse_def_period[stream->dataflow == eCapture];
> - period = 0;
> - LIST_FOR_EACH_ENTRY(dev, list, PhysDevice, entry) {
> -
>    if (strcmp(params->pulse_name, dev->pulse_name)) {
> -
>        period = dev->def_period;
> -
>        break;

The `if` condition needs inverting.  However, it would be better to combine this logic with the implmentation of `pulse_get_device_period()`. I'd suggest having `pulse_get_device_period()` call `static HRESULT get_device_period(EDataFlow flow, const char *pulse_name, REFERENCE_TIME *def, REFERENCE_TIME *min)` which could then also be used in `create_stream()`.  You'd add `get_device_period()` when you first implement `pulse_get_device_period()` and you'd put it above `create_stream()`.

Also note the second and third commits still have lowercase letters starting the commit message (and are the only two with ".drv" in the prefix).