Re: [PATCH 3/8] d3dx9: Reference top level parameter instead of dirty flag.

[Matteo Bruni]

2017-04-20 13:26 GMT+02:00 Paul Gofman :
> -static BOOL param_set_dirty_flag_ptr(void *dirty_flag_ptr, struct d3dx_parameter *param)
> +static BOOL param_set_top_level_param(void *top_level_param, struct d3dx_parameter *param)
>  {
> - param->dirty_flag_ptr = (DWORD *)dirty_flag_ptr;
> - param->top_level_param = (struct d3dx_parameter *)top_level_param;
> return FALSE;
>
> }

The cast is unnecessary (yeah, it was already unnecessary, I missed
that earlier).

It might make sense to store both? Avoiding the extra indirection in
is_param_dirty() might help a tiny bit.
It's fine to tackle this later on.