Re: [msi/tests] Install tests on win9x and NT4

[James Hawkins]

On Jan 23, 2008 5:20 AM, Paul Vriens  wrote:
> Hi,
>
> Currently the install test fail/crash on at least win95 and NT4. The main reason
> I found was that pMsiQueryComponentStateA and pMsiSourceListGetInfoA are not
> guarded.
>
> Does it makes sense to guard every instance of these calls and just continue:
>
> if (pMsiSourceListGetInfoA)
> {
>     call
>     test outcome
> }
>
> or should we skip the whole subtest when the function is not available.
>
> Guarding each single item requires 28 of these if-statements or is there an
> other alternative? (like creating a function/macro to deal with this)

Logically, guarding each call is the exact same as not running the
tests at all, so just check at the beginning of
test_MsiSourceListGetInfo and skip the tests if the pointer is NULL.