Re: [PATCH 2/2] d2d1: Introduce a registry key to limit the maximum supported factory version.

[Józef Kucia]

On Mon, Jan 22, 2018 at 1:10 PM, Henri Verbeet  wrote:
> Signed-off-by: Henri Verbeet
> -
> - if (get_config_key_dword(default_key, application_key, "max_version_factory", &d2d_settings.max_version_factory))
> -
>    ERR_(winediag)("Limiting maximum Direct2D factory version to %#x.\n", d2d_settings.max_version_factory);
> -
> - if (application_key)
> -
>    RegCloseKey(application_key);
> - if (default_key)
> -
>    RegCloseKey(default_key);
>
> +}
> -
>
> +BOOL WINAPI DllMain(HINSTANCE inst, DWORD reason, void *reserved)
> +{
> - if (reason == DLL_PROCESS_ATTACH)
> -
>    d2d_settings_init();
> - return TRUE;
> +}
>
> 2.1.4

I'm not sure, but it could make more sense to make the version setting
more general, and limit all interfaces to a given Direct2D version
instead of just the factory interface. One could specify maximum
Direct2D version in registry, e.g. 1.0, 1.1, 1.2.