Re: [v3 PATCH 1/4] mfplat: Implement MFTRegister

[Alexandre Julliard]

Alistair Leslie-Hughes  writes:
> +static HRESULT register_category(CLSID *clsid, GUID *category)
> +{
> - HKEY hcategory, htmp1, htmp2;
> - WCHAR buffer[64];
> - DWORD ret;
> -
> - if (RegOpenKeyW(HKEY_LOCAL_MACHINE, categories_keyW, &hcategory))
> -
>    return E_FAIL;
> -
> - GUIDToString(buffer, category);
> - ret = RegCreateKeyW(hcategory, buffer, &htmp1);
> - RegCloseKey(hcategory);
> - if (ret) return E_FAIL;

You should create the entire path if needed instead of failing.
> @@ -650,6 +650,10 @@ HKLM,Software\Borland\Database Engine\Settings\SYSTEM\INIT,SHAREDMEMLOCATION,,90
>  HKLM,Software\Clients\Mail,,2,"Native Mail Client"
>  HKLM,Software\Clients\Mail\Native Mail Client,,2,"Native Mail Client"
>  HKLM,Software\Clients\Mail\Native Mail Client,"DLLPath",2,"%11%\winemapi.dll"
> +HKLM,Software\Classes\MediaFoundation,,16
> +HKLM,Software\Classes\MediaFoundation\MediaSources,,16
> +HKLM,Software\Classes\MediaFoundation\Transforms,,16
> +HKLM,Software\Classes\MediaFoundation\Transforms\Categories,,16

...and then you no longer need this.