On 26.02.2017 1:13, Fabian Maurer wrote:
Thanks for the reply,
If this will stay, please use functions, not macros. STR_SIZE does not look useful.
Well, I figured it makes the code a bit easier. Should I should just write it out everywhere or make it a function?
Yes, functions, or in case of SRT_SIZE I'd just unroll it.
You can't free list node like that.
What do you mean? I allocated the list and it's contents with HeapAlloc, so I need to free it that way. Or am I missing something?
You need to unlink it first. Also regarding allocations, in comctl32 most of the time internal Alloc/Free functions are used instead of HeapAlloc(). At the end it means the same thing, but maybe we should keep the habit, if only for consistency.
Static string for that doesn't look right.
Why is that? I've looked into the other code, and strings are often defined as static const WCHAR, that was the recommended method, too. Of course that needs to be changed later, since we (probably) want to take localization into account.
Yes, that's what I mean, it should go to resources.
Regards, Fabian Maurer