Re: [PATCH vkd3d 02/13] vkd3d-shader/hlsl: Pass copy_propagation_state and hlsl_deref pointers to copy_propagation_compute_replacement().

[Zebediah Figura (she/her)]

On 12/22/21 03:23, Giovanni Mascellani wrote:
> Hi,
>
> On 22/12/21 00:08, Zebediah Figura wrote:
> > @@ -377,10 +385,15 @@ static struct hlsl_ir_node 
> > *copy_propagation_compute_replacement(struct copy_pro
> >           if (!node)
> >               node = var_def->values[offset + i].node;
> >           else if (node != var_def->values[offset + i].node)
> > +        {
> > +            TRACE("No single source for propagating load from 
> > %s[%u-%u].\n", var->name, offset, offset + count);
> >               return NULL;
> > +        }
>
> That's fine for me, but I guess that usually vkd3d's policy is that if 
> one branch of an "if ... else if ... else" chain has braces, then all of 
> them must have. Or did I misunderstand it?

Yes, that's correct, but I missed it.