Re: msi: Ignore the custom action type 51 if the source field is empty

[Paul Vriens]

James Hawkins wrote:
> Hi,
>
> Fixes bug 11891.  http://bugs.winehq.org/show_bug.cgi?id=11891
>
> Changelog:
> - Ignore the custom action type 51 if the source field is empty.
>
> dlls/msi/custom.c        |    3 ++
>  dlls/msi/tests/install.c |   65 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+), 0 deletions(-)

Hi James,

I was looking at the sudden huge amount of failures for the msi/package tests on 
Windows:

http://test.winehq.org/data/200803121000/

The issue turned out to be with the above patch for the install tests. If I run 
the install tests a 'MSITEST' package will stay around (can been seen in 
'Add/Remove Programs").

If I remove MSITEST the package tests will succeed again.

(Reverting the above patch makes the package tests pass again as well, when run 
after the install tests of course).

The thing that surprises me is that we don't see the same failures when running 
the package tests on Wine? Is this because we have 39 TODO's in there?