June 21, 2019 7:48 PM, "Henri Verbeet" hverbeet@gmail.com wrote:
This is the only user of wined3d_swapchain_resize_target(), so in principle it could now be removed from wined3d. Whether that's a good idea depends to some extent on what we're going to do with the other swapchain functions. For example, wined3d_swapchain_set_fullscreen() is also used by wined3d internally, and has some interactions with the wined3d device, so in some regards it's a more interesting case. I.e., we wouldn't want to use one approach for wined3d_swapchain_resize_target(), and then another for wined3d_swapchain_set_fullscreen(), and perhaps a third for e.g. gamma control.
While doing d3d12_swapchain_SetFullscreenState() I found that using the new helpers with d3d11 was messy without further refactoring of d3d11. I'll see what can be done with it. Testing d3d12_swapchain_ResizeTarget() needs the d3d12 fullscreen functions implemented first, so maybe it should all be one large patch.