On Thu, Oct 2, 2008 at 3:27 PM, Steven Edwards winehacker@gmail.com wrote:
On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins jhawkins@codeweavers.com wrote:
Hi, I can't repro this problem on my machine, so I'm sending this patch to patchwatcher by way of wine-patches to get some info. Please do not apply.
Regarding our wineconf discussion about patchwatcher spam on wine-patches and filtering. Perhaps we need 2 email address patches can be sent to. My thinking is the flow could be something like:
- By default everyone sends a patch to wine-patches
- If a patch gets rejected the author gets a failure mail in private,
and now retries or testing patches should go to wine-patches-testing N times until they get it right 3. once its right, patchwatch could then forward the new good patch to wine-patches or could send an email to the dev saying that its good enough to now send to wine-patches.
You'd still be sending the patch twice to wine-patches, and by that logic, for _EVERY_ patch, not just ones that were rejected.
I think the idea at Wineconf was the best: Submit patches to wine-patches Patchwatcher does its voodoo magic If patch is good -> wine-patches-approved If patch fails -> wine-patches-rejected + e-mail to author
However, I think your idea has merit...if Dan would be willing, could add a test e-mail, that doesn't spam everyone, for testing only on patchwater. I.e., patch-test@kegel.com. Results would then join the rest on the results page (or possibly just e-mailed back, but that seems like more work for little gain.
-Austin