Re: [2/4] advapi32: Add a basic implementation of LsaLookupNames2.

[Nikolay Sivov]

Hans Leidekker wrote:
> diff --git a/dlls/advapi32/lsa.c b/dlls/advapi32/lsa.c
> index 315cce9..edb20d8 100644
> --- a/dlls/advapi32/lsa.c
> +++ b/dlls/advapi32/lsa.c
> @@ -297,19 +297,88 @@ NTSTATUS WINAPI LsaLookupNames(
>      return STATUS_NONE_MAPPED;
>  }
>
> +static BOOL lookup_name(LSA_UNICODE_STRING *name, SID *sid, DWORD *sid_size, WCHAR *domain,
> -
>                    DWORD *domain_size, SID_NAME_USE *use, BOOL *handled)
>
> +{
> - BOOL ret;
> -
> - ret = lookup_local_wellknown_name(name, sid, sid_size, domain, domain_size, use, handled);
> - if (!handled)
> -
>    ret = lookup_local_user_name(name, sid, sid_size, domain, domain_size, use, handled);
> -
> - return ret;
>
> +}

This looks strange. Shouldn't be " if (!*handled) " or " if (!ret) "?