Re: [PATCH] conhost: Set focus to correct radio button in save dialog

[Jacek Caban]

Hi Hugh,

On 8/30/21 2:04 PM, Hugh McMaster wrote:
> diff --git a/programs/conhost/window.c b/programs/conhost/window.c
> index 48cd9ed6f6b..ad707531bd2 100644
> --- a/programs/conhost/window.c
> +++ b/programs/conhost/window.c
> @@ -1819,7 +1819,8 @@ static INT_PTR WINAPI save_dialog_proc( HWND dialog, UINT msg, WPARAM wparam, LP
>       {
>       case WM_INITDIALOG:
>           SendDlgItemMessageW( dialog, IDC_SAV_SESSION, BM_SETCHECK, BST_CHECKED, 0 );
> -
>    break;
> -
>    SetFocus( GetDlgItem( dialog, IDC_SAV_SESSION ) );

I think that SetFocus should not be used directly on dialogs, this 
should probably use WM_NEXTDLGCTL instead.

Thanks,

Jacek