On Mon, 2017-05-15 at 16:39 -0300, Bruno Jesus wrote:
On Mon, May 15, 2017 at 4:27 PM, Jacek Caban jacek@codeweavers.com wrote:
... Sorry about that, I will send a fixed version. However, this rises my other related concern. What do you think about changing this code to always use winsock? We'd use single implementation, making the code cleaner and avoiding breaking other configs. I guess the original reasoning was combination of performance and less mature winsock implementation at the time. I don't think winsock overhead would be too bad in this case and ws2_32 should be up to the task.
I would vote for that, wininet was already changed and we had some discussion about changing winhttp too [1] but Hans was not amused with the idea ;-)
Yes, there was a strong argument for moving wininet: apps depending on winsock initialization. rpcrt4 has two implementations, one based on Unix sockets and one based on Windows sockets. It may make sense to have just the Windows version if performance is acceptable.
Maybe this is a good time to discuss again (?). Having a single point of network input/output will simplify network debugging IMO.
Right, because we just fixed the last winsock bug ;-)