On Mon, Feb 15, 2010 at 9:34 AM, Aric Stewart aric@codeweavers.com wrote:
Hi,
I am really happy that you are helping with the msctf stuff I started. Very cool!
2 quick things.
- typedef struct tagACLMulti, don't call it tagACLMulti. I am sure this
is from copying from threadmgr.c where it is a copy/paste thing from when I started that framework. It has always bugged me (though not enough to submit a patch just to change it), but it would be nice not to see it propagated even more.
Done
- you add pITfLangBarMgr to the ActivatedTextService, but dont do anything
with it. Does the Activated TextService need to have a reference to the ITfLangBarMgr? My quick read though does not seem to reveal that. When should it get set and initialized and where would it be used?
Ya, I've found no evidence either, shouldn't have been there.
thanks! -aric
Thanks for the review and feedback Aric! I've resubmitted with the changes above.
Justin