On Mon, Oct 6, 2008 at 3:39 AM, Henri Verbeet hverbeet@gmail.com wrote:
2008/10/6 Austin English austinenglish@gmail.com:
- if(DepthStencilFormat != WINED3DFMT_D24S8)
FIXME("Add OpenGL context recreation support to SetDepthStencilSurface\n");
- if(DepthStencilFormat != WINED3DFMT_D24S8) {
if (warn) {FIXME("Add OpenGL context recreation support to SetDepthStencilSurface\n");warn = FALSE;}- }
Style issues aside, I don't think so. That FIXME is quite valid, and doesn't get printed *that* often. If you don't want to see the output, run with WINEDEBUG=-all, it should give a small performance boost as well.
At WineConf, we agreed to quiet the nosiest fixme's. I've been monitoring my own apps I run, as well as Bugzilla logs to see which ones are the noisiest. That one was one, and as it doesn't have any variables it prints, never changes, so doesn't need to be printed hundreds of times in a log.
Yes, we all know that WINEDEBUG=-all can be used to silence everything, but the consensus at WineConf was to reduce the output, so it doesn't seem as scary. Those users that know about -all are likely the same ones that know fixme's are not bugs.
-Austin