2009/6/10 Austin English austinenglish@gmail.com:
On Tue, Jun 9, 2009 at 7:14 AM, Ben Kleinshacklein@gmail.com wrote:
I've occasionally got compilation errors while doing a git bisect. As there is no way to fix this (assuming there's nothing wrong with libs on my system, since every other revision I try gets built fine) without manually hacking at the git repository (which is a very bad idea for all sorts of reasons), I just mark that revision as bad and continue.
That's a very poor practice, leading to wrong regression test results. The proper thing to do is either: A) fix the compile manually, then revert your change before the next git bisect {good,bad} B) use 'git bisect skip'.
Now that you mention it, B sounds very familiar. I believe that is what I used. Regardless, my test did find the correct patch at the time and the author was able to provide a fix for me :)
My apologies, I've been hideously tired and stressed recently.