On Monday 22 October 2007 13:15:57 Jeff Latimer wrote:
In this case the fix is for a Null reference as indicated in the accompanying tests. The test prangs in the current build and the patch for pdh_main.c fixes the behaviour on XP. As I said, I can't tell if it
How can a fix to pdh_main.c (which is Wine's implementation) fix something on XP?
fixes it in anything else. However, there needs to be a fix for the NULL reference and the case of needing a buffer if size and index > 0 seems to be reasonable behaviour.
When a test fails on some version of Windows something is wrong with the test itself. Possible solutions are to make the test accept the different behavior too or to remove the test altogether when it is sufficiently clear that applications cannot depend on any particular behaviour.
-Hans