Nikolay Sivov bunglehead@gmail.com wrote:
/* FIXME: check other BS_* handlers */if (btn_type == BS_GROUPBOX)InflateRect(&rc, -7, 1); /* GB_Paint does this */How about doing what FIXME suggests?
Sure, at some point. Original report is for group box, fix is limited to it.
Yes, my original patch is only for BS_GROUPBOX buttons, but that doesn't mean that other button style handlers don't have similar bugs. There are not that much of button styles to carfully review and fix if required, and if for some reason you've decided to resubmit the staged patches you should be prepared to spend time to improve the original patches, in this particular case take care of the FIXME.
Adding some tests wouldn't hurt either.
Test what, filled rectangle size? I don't think it makes sense.
This patchset fixes several things, and each of them deserves its own testing. For instance testing an original font selected into DC should be easy enough.
There are multiple reasons why staged patches are not sent directly to wine-patches, and one of them is that they need more work. If you are not ready to do that part of the work (except of just copy/pasting an original patch) then you shouldn't touch the staged patches.