Re: [PATCH V2] winspool.drv: Implement AddPrintProcessorA via AddPrintProcessorW

[Vijay Kiran Kamuju]

On Mon, Jun 1, 2020 at 11:06 AM Dmitry Timoshkov  wrote:
> Vijay Kiran Kamuju  wrote:
> > - TRACE("(%s,%s,%s,%s): stub\n", debugstr_a(pName), debugstr_a(pEnvironment),
> >       debugstr_a(pPathName), debugstr_a(pPrintProcessorName));
>
> ": stub" doesn't belong to a TRACE.

Yes, will fix it.
> > - RtlFreeUnicodeString(&ProcessorW);
> > - RtlFreeUnicodeString(&PathW);
> > - RtlFreeUnicodeString(&EnvW);
> > - RtlFreeUnicodeString(&NameW);
>
> This could be a simple HeapFree, have a look at other places that use
> asciitounicode(). I have to admit, that asciitounicode() is an over-
> engineering, and could be replaced by simple strdupAtoW() in most (if
> not all) places.

Since I am using asciitounicode(), RtlFreeUnicodeString is the right function
than HeapFree (and type conversion is needed). We need to introduce this
helper strdupAtoW() and do conversion, which is a separate patch series if
asciitounicode() is overkill.
--
Vijay
> --
> Dmitry.