Re: [TRY2 1/8] gdi32: Cleanup the update_font_info().

[Huw Davies]

On Wed, Oct 04, 2006 at 11:26:49AM +0900, Byeong-Sik Jeon wrote:
> Changelog:
> Cleanup the updata_font_info().
>
> +static void add_nls_font_to_registry(
> -
>    HKEY hkey,
> -
>    const char *value_name,
> -
>    const char *value_data,
> -
>    BOOL is_force)

....
> - {
> -
>    RegSetValueExA(hkey, value_name, 0, REG_SZ,
> -
>                   (const BYTE *)value_data, (DWORD)(strlen(value_data) + 1));
> - }

You shouldn't need the DWORD cast here.
> @@ -1546,6 +1528,7 @@ static void update_font_info(void)
> - if(!matched_nls_font_list)
> - {
> -
>    FIXME("there is no font defaults for lcid %04lx/ansi_cp %u", lcid, ansi_cp);
> -
>    return;
> - }

Could you add the missing \n in the FIXME and change the text to read
"There are no..."?

Thanks,
Huw.