Re: [PATCH 1/2] kernelbase: Add stub for SetThreadDescription().

[Zhiyi Zhang]

On 11/4/19 7:08 PM, Conor McCarthy wrote:
> Required by Hitman 2.
> Signed-off-by: Conor McCarthy
>
> .../api-ms-win-core-processthreads-l1-1-3.spec         |  2 +-
>  dlls/kernel32/kernel32.spec                            |  1 +
>  dlls/kernelbase/kernelbase.spec                        |  2 +-
>  dlls/kernelbase/thread.c                               | 10 ++++++++++
>  4 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/api-ms-win-core-processthreads-l1-1-3/api-ms-win-core-processthreads-l1-1-3.spec b/dlls/api-ms-win-core-processthreads-l1-1-3/api-ms-win-core-processthreads-l1-1-3.spec
> index 3b57e1c8..f8f5a870 100644
> --- a/dlls/api-ms-win-core-processthreads-l1-1-3/api-ms-win-core-processthreads-l1-1-3.spec
> +++ b/dlls/api-ms-win-core-processthreads-l1-1-3/api-ms-win-core-processthreads-l1-1-3.spec
> @@ -5,6 +5,6 @@
>  @ stub GetThreadSelectedCpuSets
>  @ stub SetProcessDefaultCpuSets
>  @ stub SetProcessInformation
> -@ stub SetThreadDescription
> +@ stdcall SetThreadDescription(ptr ptr) kernel32.SetThreadDescription
>  @ stdcall SetThreadIdealProcessor(long long) kernel32.SetThreadIdealProcessor
>  @ stub SetThreadSelectedCpuSets
> diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
> index 23c25b7a..347d2da2 100644
> --- a/dlls/kernel32/kernel32.spec
> +++ b/dlls/kernel32/kernel32.spec
> @@ -1447,6 +1447,7 @@
>  @ stdcall SetTermsrvAppInstallMode(long)
>  @ stdcall SetThreadAffinityMask(long long)
>  @ stdcall -import SetThreadContext(long ptr)
> +@ stdcall -import SetThreadDescription(ptr ptr)

The last parameter should be wstr.
> @ stdcall -import SetThreadErrorMode(long ptr)
>  @ stdcall SetThreadExecutionState(long)
>  @ stdcall -import SetThreadGroupAffinity(long ptr ptr)
> diff --git a/dlls/kernelbase/kernelbase.spec b/dlls/kernelbase/kernelbase.spec
> index c1fa4795..743c48c2 100644
> --- a/dlls/kernelbase/kernelbase.spec
> +++ b/dlls/kernelbase/kernelbase.spec
> @@ -1478,7 +1478,7 @@
>  @ stdcall SetSystemTime(ptr)
>  @ stdcall SetSystemTimeAdjustment(long long) kernel32.SetSystemTimeAdjustment
>  @ stdcall SetThreadContext(long ptr)
> -# @ stub SetThreadDescription
> +@ stdcall SetThreadDescription(ptr ptr)
>  @ stdcall SetThreadErrorMode(long ptr)
>  @ stdcall SetThreadGroupAffinity(long ptr ptr)
>  @ stdcall SetThreadIdealProcessor(long long)
> diff --git a/dlls/kernelbase/thread.c b/dlls/kernelbase/thread.c
> index 0cac2b69..f6823640 100644
> --- a/dlls/kernelbase/thread.c
> +++ b/dlls/kernelbase/thread.c
> @@ -387,6 +387,16 @@ BOOL WINAPI DECLSPEC_HOTPATCH SetThreadContext( HANDLE thread, const CONTEXT *co
>  }
>
> +/***********************************************************************
> -
> -
>       SetThreadDescription   (kernelbase.@)
> - */
>
> +HRESULT WINAPI DECLSPEC_HOTPATCH SetThreadDescription( HANDLE thread, PCWSTR description )
> +{
> - FIXME( "(%p %p): stub\n", thread, description );

It use %s and wine_dbgstr_w(description).
> - return E_NOTIMPL;
>
> +}
> -
> -
>
> /***********************************************************************
> -
>       SetThreadErrorMode   (kernelbase.@)
>
> */