Re: Security bug in ShellExecuteEx()

[Michael Stefaniuc]

Hello,

On Fri, Apr 09, 2004 at 02:14:10AM +0200, Francois Gouget wrote:
> Index: dlls/shell32/shlexec.c
>
> RCS file: /var/cvs/wine/dlls/shell32/shlexec.c,v
> retrieving revision 1.40
> diff -u -r1.40 shlexec.c
> --- a/dlls/shell32/shlexec.c	7 Apr 2004 03:49:51 -0000	1.40
> +++ b/dlls/shell32/shlexec.c	8 Apr 2004 23:12:53 -0000
> @@ -1114,10 +1126,6 @@
>          strcatW(wszApplicationName, wszCommandline);
>      }
> - retval = execfunc(wszApplicationName, NULL, FALSE, &sei_tmp, sei);
> - if (retval > 32)
> -
>    return TRUE;
> - /* Else, try to find the executable */

^^^^^ You may want to remove this because it refers to the
    	just removed if.
>  wcmd[0] = '\0';
>  retval = SHELL_FindExecutable(sei_tmp.lpDirectory, lpFile, sei_tmp.lpVerb, wcmd, 1024, lpstrProtocol, &env, sei_tmp.lpIDList, sei_tmp.lpParameters);

bye
    michael