Re: [PATCH v2 1/2] kernel32/tests: Add tests for LCMapStringW

[Alexandre Julliard]

Fabian Maurer  writes:
> +static void test_LCMapString_sortkey(void)
> +{
> - OSVERSIONINFOA osversion;
> -
> - osversion.dwOSVersionInfoSize = sizeof(osversion);
> - GetVersionExA(&osversion);
> -
> - if (broken(osversion.dwMajorVersion != 6 || osversion.dwMinorVersion != 1))
> - {
> -
>    skip("Unicode sorting table tests only implemented for win7. Current version is %d.%d\n", osversion.dwMajorVersion, osversion.dwMinorVersion);
> -
>    return;
> - }
> -
> - /* Tests against the Win7 sorting tables */
> -
> -
> /* en-US */
> - todo_wine
> - run_sortkey_test(0x0409, L"abc\ue604\u00c1", sortkey_results_win7_default, 0); /* Default case */
> - todo_wine
> - run_sortkey_test(0x0409, L"\u02f4\u02f4\u02f4", sortkey_results_win7_type1, 0); /* Type 1 */
> - todo_wine
> - run_sortkey_test(0x0409, L"ab\uff0c\u2a74\u2364\u265f\u29d8\u2ff3yz", sortkey_results_win7_symbols1, 0); /* Symbols */
> - todo_wine
> - run_sortkey_test(0x0409, L"ab\uff0c\u2a74\u2364\u265f\u29d8\u2ff3yz", sortkey_results_win7_symbols2, NORM_IGNORESYMBOLS); /* Symbols */
> - todo_wine
> - run_sortkey_test(0x0409, L"ab\u208b\u058ayz", sortkey_results_win7_punctuation1, 0); /* Punctuation */

This clearly needs to be a table of some kind. Also you should find a
way to test all Windows versions, preferably without having to hardcode
a ton of sortkey values for every version.