Re: [PATCH 2/2] winevulkan: add VulkanInstanceCreateInfo tracing.

[Józef Kucia]

Please fix the subject: "winevulkan: Add VkInstanceCreateInfo tracing."

On Mon, Mar 19, 2018 at 1:41 AM, Roderick Colenbrander
 wrote:
> Signed-off-by: Roderick Colenbrander
>
> dlls/winevulkan/vulkan.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c
> index 87c871d0f4..43c05f67b7 100644
> --- a/dlls/winevulkan/vulkan.c
> +++ b/dlls/winevulkan/vulkan.c
> @@ -206,10 +206,22 @@ static BOOL wine_vk_init(void)
>  static VkResult wine_vk_instance_convert_create_info(const VkInstanceCreateInfo *src,
>          VkInstanceCreateInfo *dst)
>  {
> -
>
> unsigned int i;
> -
>
> dst->sType = src->sType;
>    dst->flags = src->flags;
>    dst->pApplicationInfo = src->pApplicationInfo;
> -
>
> if (dst->pApplicationInfo)
> -
>
> {
> -
>    const VkApplicationInfo *app_info = dst->pApplicationInfo;
> -
>    TRACE("pApplicationName %s, applicationVersion %d\n",
> -
>            debugstr_a(app_info->pApplicationName), app_info->applicationVersion);
> -
>    TRACE("pEngineName %s, engineVersion %d\n", debugstr_a(app_info->pEngineName),
> -
>             app_info->engineVersion);
> -
>    TRACE("apiVersion %#x\n", app_info->apiVersion);

Please use %#x to trace the application and engine version. It could
be nicer to not use the exact names of fields from VkApplicationInfo,
e.g.

"Application name %s, application version %#x\n",
"Engine name %s, engine version %#x\n",
"API version "%#x\n".
> - }
> - /* Application and loader can pass in a chain of extensions through pNext.
>     * We can't blindly pass these through as often these contain callbacks or
>     * they can even be pass structures for loader / ICD internal use. For now
>
> @@ -248,6 +260,12 @@ static VkResult wine_vk_instance_convert_create_info(const VkInstanceCreateInfo
>      dst->ppEnabledExtensionNames = src->ppEnabledExtensionNames;
>      dst->enabledExtensionCount = src->enabledExtensionCount;
> - TRACE("Enabled extensions: %d\n", dst->enabledExtensionCount);

Please use %u.
> - for (i = 0; i < dst->enabledExtensionCount; i++)
> - {
> -
>    TRACE("Extension %d: %s\n", i, dst->ppEnabledExtensionNames[i]);

Please use %u and debugstr_a().
> - }
> - return VK_SUCCESS;
>
> }
>
> --
> 2.14.3